Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11401 )
Change subject: [gutil] add LookupOrEmplace() ...................................................................... Patch Set 3: > > The change looks fine with me, though I think Adar may the same > change lying around somewhere. > > Yeah, out for review here: https://gerrit.cloudera.org/c/11140. > Same exact implementation. > > Happy to see it land earlier though. Woops, I didn't pay attention to the series of delta-related patches. Thank you for the review! -- To view, visit http://gerrit.cloudera.org:8080/11401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a177f410c1d4ed33e6f44cb7d6c33d6141f84fc Gerrit-Change-Number: 11401 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Mon, 10 Sep 2018 20:34:49 +0000 Gerrit-HasComments: No