Will Berkeley has posted comments on this change. (
http://gerrit.cloudera.org:8080/11381 )
Change subject: KUDU-2566: Enhance rowset tree pruning and stop coping string
while querying
......................................................................
Patch Set 6:
(5 comments)
LGTM once Adar's and my nits are addressed.
http://gerrit.cloudera.org:8080/#/c/11381/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11381/6//COMMIT_MSG@7
PS6, Line 7: string
strings
http://gerrit.cloudera.org:8080/#/c/11381/6//COMMIT_MSG@7
PS6, Line 7: coping
copying
http://gerrit.cloudera.org:8080/#/c/11381/6//COMMIT_MSG@8
PS6, Line 8: while querying
I think git only uses the first line as the subject so inserting a line break
will truncate the subject as displayed in e.g. git log --oneline.
http://gerrit.cloudera.org:8080/#/c/11381/6/src/kudu/util/interval_tree-inl.h
File src/kudu/util/interval_tree-inl.h:
http://gerrit.cloudera.org:8080/#/c/11381/6/src/kudu/util/interval_tree-inl.h@402
PS6, Line 402: interval
> Nit: 'intervals' was correct; this deals with multiple intervals.
I think 'interval' can be singular or plural as long as the rest of the
sentence agrees:
"Any interval whose left edge is < the query interval's right edge intersects
the query interval"
or
"Any intervals whose left edges are < the query interval's right edge intersect
the query interval"
but the former sounds better to me.
http://gerrit.cloudera.org:8080/#/c/11381/6/src/kudu/util/interval_tree-test.cc
File src/kudu/util/interval_tree-test.cc:
http://gerrit.cloudera.org:8080/#/c/11381/6/src/kudu/util/interval_tree-test.cc@59
PS6, Line 59: // boost::none means infinity.
: // [left, right] is closed interval.
: // [lower, upper) is half-open interval, so the upper is
exclusive.
This and the pictures are great. Thanks for adding them!
--
To view, visit http://gerrit.cloudera.org:8080/11381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e34b4169f93f3519f694c9bf86ca5295c318e79
Gerrit-Change-Number: 11381
Gerrit-PatchSet: 6
Gerrit-Owner: helifu <hzhel...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 22:47:08 +0000
Gerrit-HasComments: Yes
