Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11415 )
Change subject: move KUDU_NO_EXPORT attribute on methods ...................................................................... move KUDU_NO_EXPORT attribute on methods The original location was ineffective due to a bug in older versions of GCC, [1] appears to be the best tracking issue. Adding the annotation at the end of the method signature silences the warnings on GCC 4.8, and maintains symbol hiding as checked with nm. [1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30361 Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57 Reviewed-on: http://gerrit.cloudera.org:8080/11415 Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Kudu Jenkins --- M src/kudu/client/client.h 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57 Gerrit-Change-Number: 11415 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins
