Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11429 )
Change subject: [catalog_manager] optimization in AsyncAddReplicaTask ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11429/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/11429/1/src/kudu/master/catalog_manager.cc@3474 PS1, Line 3474: excluded.emplace(std::move(desc)); > Nit: EmplaceOrDie() Done http://gerrit.cloudera.org:8080/#/c/11429/1/src/kudu/master/catalog_manager.cc@3480 PS1, Line 3480: auto replacement_replica = SelectReplica(ts_descs, excluded, rng_); > Does SelectReplica() assume that every member of 'excluded' must be in 'ts_ SelectReplica() does not assume that 'excluded' to be among 'ts_descs'. The 'presumably dead' servers are not included into 'ts_descs', but they might be in the 'excluded' set. That should work as expected. Overall it's a good point; I add a comment about that to clarify. -- To view, visit http://gerrit.cloudera.org:8080/11429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f46ef2e3e3f385f0abc7e02e521e03d47569413 Gerrit-Change-Number: 11429 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 12 Sep 2018 05:31:38 +0000 Gerrit-HasComments: Yes
