Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/10406 )
Change subject: KUDU-2437 Split a tablet into primary key ranges by size ...................................................................... Patch Set 23: (2 comments) Hi, Adar Dembo Thanks for review. I have updated the patch. :) http://gerrit.cloudera.org:8080/#/c/10406/22/src/kudu/tablet/rowset_info.h File src/kudu/tablet/rowset_info.h: http://gerrit.cloudera.org:8080/#/c/10406/22/src/kudu/tablet/rowset_info.h@59 PS22, Line 59: Slice start_key, : Slice stop_key, > Since you're passing these by copy, no need for 'const'; the caller and cal Done http://gerrit.cloudera.org:8080/#/c/10406/22/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/10406/22/src/kudu/tablet/tablet.h@441 PS22, Line 441: column_ > Nit: 'column_ids' Done -- To view, visit http://gerrit.cloudera.org:8080/10406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ec4395919f4b54102e458ef5154334c08412e8a Gerrit-Change-Number: 10406 Gerrit-PatchSet: 23 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Tue, 18 Sep 2018 05:27:26 +0000 Gerrit-HasComments: Yes
