Hello Mike Percy, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11475 to look at the new patch set (#5). Change subject: [test] Adjust Kudu binary locator logic. ...................................................................... [test] Adjust Kudu binary locator logic. This patch adjusts the binary locating logic to be less fragile and more externally useful. It also breaks the logic out of the TestUtils class into it’s own class. I broke out the remaining TestUtils methods as well and remove any that were unused. This patch also adjusts the Maven and Gradle build to define the `kuduBinDir` system property. Doing this means we don’t need to detect git repos and search the repository for binaries. This also fixes the issue where Maven tests would fail to locate the binary because they were using jars installed into the local repository. Change-Id: I365dfb9fdeeb4fd985f370a6b8305345e0a2ac7d --- M java/README.adoc M java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java M java/gradle/tests.gradle M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java D java/kudu-client/src/test/java/org/apache/kudu/client/TestTestUtils.java D java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java A java/kudu-client/src/test/java/org/apache/kudu/util/KuduBinaryLocator.java A java/kudu-client/src/test/java/org/apache/kudu/util/ProtobufUtils.java A java/kudu-client/src/test/java/org/apache/kudu/util/RandomUtils.java M java/pom.xml 14 files changed, 232 insertions(+), 365 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/11475/5 -- To view, visit http://gerrit.cloudera.org:8080/11475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I365dfb9fdeeb4fd985f370a6b8305345e0a2ac7d Gerrit-Change-Number: 11475 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org>