Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11474 )
Change subject: [test] Clean up MiniKuduCluster and BaseKuduTest ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/11474/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11474/4//COMMIT_MSG@16 PS4, Line 16: it with our own HostAndPort which wraps an Nit: extra leading space here. http://gerrit.cloudera.org:8080/#/c/11474/4/java/kudu-client/src/main/java/org/apache/kudu/client/HostAndPort.java File java/kudu-client/src/main/java/org/apache/kudu/client/HostAndPort.java: PS4: License header. http://gerrit.cloudera.org:8080/#/c/11474/4/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java: http://gerrit.cloudera.org:8080/#/c/11474/4/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@295 PS4, Line 295: hostAndPort Style nit: for local variables with really short scopes, I prefer shorter names. For example 'hp' here would be sufficient. http://gerrit.cloudera.org:8080/#/c/11474/4/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@484 PS4, Line 484: address Nit: the other methods earlier name this argument hostAndPort rather than address. Below too. http://gerrit.cloudera.org:8080/#/c/11474/4/java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java File java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java: http://gerrit.cloudera.org:8080/#/c/11474/4/java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java@38 PS4, Line 38: InetSocketAddress HostAndPort Below too. -- To view, visit http://gerrit.cloudera.org:8080/11474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a55c41f48f31c4a12b41508dbb343c4419e65b1 Gerrit-Change-Number: 11474 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 22:19:40 +0000 Gerrit-HasComments: Yes
