Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 )
Change subject: [tools] ksck checksums: Factor out of main ksck code ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/11488/1/src/kudu/integration-tests/cluster_verifier.h File src/kudu/integration-tests/cluster_verifier.h: http://gerrit.cloudera.org:8080/#/c/11488/1/src/kudu/integration-tests/cluster_verifier.h@24 PS1, Line 24: #include "kudu/util/status.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/11488/1/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/11488/1/src/kudu/tools/ksck.h@513 PS1, Line 513: Status ChecksumData(const KsckChecksumOptions& options); > warning: function 'kudu::tools::Ksck::ChecksumData' has a definition with d Done http://gerrit.cloudera.org:8080/#/c/11488/1/src/kudu/tools/ksck_checksum.h File src/kudu/tools/ksck_checksum.h: http://gerrit.cloudera.org:8080/#/c/11488/1/src/kudu/tools/ksck_checksum.h@31 PS1, Line 31: class KsckResults; > warning: no definition found for 'KsckResults', but a definition with the s Done http://gerrit.cloudera.org:8080/#/c/11488/1/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/11488/1/src/kudu/tools/ksck_checksum.cc@29 PS1, Line 29: #include "kudu/tools/ksck.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/11488/1/src/kudu/tools/ksck_checksum.cc@34 PS1, Line 34: using std::cout; > warning: using decl 'cout' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/11488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bb1f51af22ab0c6c20b9426dbb62ea48413ed5b Gerrit-Change-Number: 11488 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 20 Sep 2018 22:59:00 +0000 Gerrit-HasComments: Yes
