Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11428 )
Change subject: KUDU-2463 pt 3: don't scan if MVCC hasn't moved ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/11428/7/src/kudu/tablet/mvcc.cc File src/kudu/tablet/mvcc.cc: http://gerrit.cloudera.org:8080/#/c/11428/7/src/kudu/tablet/mvcc.cc@51 PS7, Line 51: mestamp() == Timestamp::kI > why do we care about this and not just the return value of GetCleanTimestam It's not particularly important we do it this way; I chose this because this is the initial state. I'll go with GetCleanTimestamp(). -- To view, visit http://gerrit.cloudera.org:8080/11428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc0f77673e1f04a34ab1f5c1930bbaa2498b39bf Gerrit-Change-Number: 11428 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 21 Sep 2018 00:00:13 +0000 Gerrit-HasComments: Yes
