Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11524 )
Change subject: KUDU-2541: Fill out basic sentry client API ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11524/1/src/kudu/sentry/sentry_client.cc File src/kudu/sentry/sentry_client.cc: http://gerrit.cloudera.org:8080/#/c/11524/1/src/kudu/sentry/sentry_client.cc@80 PS1, Line 80: } > warning: do not use 'else' after 'return' [readability-else-after-return] Done -- To view, visit http://gerrit.cloudera.org:8080/11524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1004a11506ed109d1f23389ca73d95a34c32c194 Gerrit-Change-Number: 11524 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 26 Sep 2018 20:25:44 +0000 Gerrit-HasComments: Yes