Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11516 )
Change subject: tserver: log a message when a scanner is not found ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11516/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11516/2//COMMIT_MSG@26 PS2, Line 26: > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/11516/3/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/11516/3/src/kudu/tserver/tablet_service.cc@1271 PS3, Line 1271: "ScannerKeepAlive: " << s.ToString() << ": " : << Substitute("remote=$0", context->requestor_string()); > nit: maybe, use Substitute() for the whole message here Done http://gerrit.cloudera.org:8080/#/c/11516/3/src/kudu/tserver/tablet_service.cc@2020 PS3, Line 2020: LOG(INFO) << "Scan: " << s.ToString() << ": " : << Substitute("call sequence id=$0, remote=$1", : req->call_seq_id(), rpc_context->requestor_string()); > nit: maybe, use Substitute() for the whole message here Done -- To view, visit http://gerrit.cloudera.org:8080/11516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4e9c69160605d4a839ac2d28def67f4d3402b90 Gerrit-Change-Number: 11516 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 26 Sep 2018 23:48:02 +0000 Gerrit-HasComments: Yes
