Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11579 )
Change subject: KUDU-1592 Make warnings about FBM more ominous ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11579/1/docs/troubleshooting.adoc File docs/troubleshooting.adoc: http://gerrit.cloudera.org:8080/#/c/11579/1/docs/troubleshooting.adoc@85 PS1, Line 85: This results in a very large number of file descriptors that : the tablet server needs to open even with small amounts of data, which is a : limited resource and the tablet servers can easily exhaust it with file block manager. This isn't true; the FileCache will recycle file descriptors on an LRU basis in order to keep the total open fd count below a certain threshold. That doesn't detract from the larger argument (that it's not as performant) though. http://gerrit.cloudera.org:8080/#/c/11579/1/docs/troubleshooting.adoc@89 PS1, Line 89: One more reason why file block manager should be avoided is that it's : *impossible to switch between block managers* without wiping and reinitializing : the tablet servers. Combine this into the previous paragraph. http://gerrit.cloudera.org:8080/#/c/11579/1/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/11579/1/src/kudu/fs/fs_manager.cc@70 PS1, Line 70: File Nit: "The file block manager..." -- To view, visit http://gerrit.cloudera.org:8080/11579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1 Gerrit-Change-Number: 11579 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 04 Oct 2018 18:21:32 +0000 Gerrit-HasComments: Yes
