Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11712 )
Change subject: sentry module: introduce using declarations for generated types ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11712/1/src/kudu/sentry/thrift_operators-test.cc File src/kudu/sentry/thrift_operators-test.cc: http://gerrit.cloudera.org:8080/#/c/11712/1/src/kudu/sentry/thrift_operators-test.cc@31 PS1, Line 31: > Sure, I thought we always preferred using KuduTest, but that works for me. Nah we have a good number of tests that don't use KuduTest: $ for t in $(find -name *-test.cc -o -name *-itest.cc); do grep -ql ^TEST\( $t && echo $t; done | wc -l 60 -- To view, visit http://gerrit.cloudera.org:8080/11712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51f61eedc1069d362fa1ce26ce0449cce8f0846b Gerrit-Change-Number: 11712 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 17 Oct 2018 21:19:07 +0000 Gerrit-HasComments: Yes
