Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11737 )
Change subject: De-flake ASAN TestSimultaneousLeaderTransferAndAbruptStepdown ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11737/1/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/11737/1/src/kudu/tools/kudu-admin-test.cc@1495 PS1, Line 1495: every second nit: this is not the case for ASAN now. http://gerrit.cloudera.org:8080/#/c/11737/1/src/kudu/tools/kudu-admin-test.cc@1511 PS1, Line 1511: SleepFor(leader_change_period); Just a thought about making it more stable (just in case of this fix is not 'fixing' it enough): as an alternative approach it might make sense to monitor the number of inserted rows and increase or decrease the time interval between step down requests. -- To view, visit http://gerrit.cloudera.org:8080/11737 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3237f3fde48daeb2f307dfb78d457217df2beed Gerrit-Change-Number: 11737 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 18:40:30 +0000 Gerrit-HasComments: Yes
