Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11748 )
Change subject: [rebalancer] location-aware rebalancer (part 7/n) ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/11748/1/src/kudu/tools/rebalancer.h File src/kudu/tools/rebalancer.h: http://gerrit.cloudera.org:8080/#/c/11748/1/src/kudu/tools/rebalancer.h@326 PS1, Line 326: If 'location' is boost::none, rebalance across : // locations. > The idea is that this balances within a location if 'location' is not boost Woops, that's just a stale comment. I updated it. http://gerrit.cloudera.org:8080/#/c/11748/1/src/kudu/tools/rebalancer.cc File src/kudu/tools/rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/11748/1/src/kudu/tools/rebalancer.cc@257 PS1, Line 257: > in Done http://gerrit.cloudera.org:8080/#/c/11748/1/src/kudu/tools/rebalancer.cc@289 PS1, Line 289: // TODO(aserbin): it would be nice to run these rebalancers in parallel > Yeah, I think that's a good idea. But also worth saving for a followup-once Ack. http://gerrit.cloudera.org:8080/#/c/11748/1/src/kudu/tools/rebalancer_tool-test.cc File src/kudu/tools/rebalancer_tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11748/1/src/kudu/tools/rebalancer_tool-test.cc@1170 PS1, Line 1170: This tests > These tests are Done http://gerrit.cloudera.org:8080/#/c/11748/1/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/11748/1/src/kudu/tools/tool_action_cluster.cc@107 PS1, Line 107: envolves > involves Done -- To view, visit http://gerrit.cloudera.org:8080/11748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ace790aad1c1a4605ef90f6df2104f4a228a5b5 Gerrit-Change-Number: 11748 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 23 Oct 2018 19:05:28 +0000 Gerrit-HasComments: Yes
