Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 )
Change subject: [location_awareness] Add ts location to TSInfoPB ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@74 PS5, Line 74: Add a call to SetUpConfig() here. Then you won't need to override SetUp() in your new test fixture. http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@216 PS5, Line 216: CheckMasterTableCreation(table_name, 8); You need to surround these calls with NO_FATALS(); otherwise, errors in CheckMasterTableCreation() won't be checked until the end of the test. http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@294 PS5, Line 294: EXPECT_EQ("", resp.tablet_locations(0).replicas(0).ts_info().location()); : EXPECT_EQ("", resp.tablet_locations(0).replicas(1).ts_info().location()); : EXPECT_EQ("", resp.tablet_locations(0).replicas(2).ts_info().location()); Nit: do this in a loop. -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 5 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 24 Oct 2018 14:17:24 +0000 Gerrit-HasComments: Yes
