Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11923 )
Change subject: [location_awareness] Register client with location when connect to cluster ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/client/client-internal.cc@714 PS6, Line 714: location_ = connect_response.client_location(); Does location_ need to be protected by leader_master_lock_? Why or why not? http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/master-test.cc@1635 PS6, Line 1635: ASSERT_OK(proxy_->ConnectToMaster(req, &resp, &rpc)); Should also ASSERT that !resp.has_error. http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/ts_descriptor.h File src/kudu/master/ts_descriptor.h: http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/ts_descriptor.h@182 PS6, Line 182: class ClientDescriptor { Why is GetClientLocation stored in this class? Do you envision adding more content to it in the near future? http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/ts_descriptor.cc@411 PS6, Line 411: string location_temp; I don't think this indirection is needed; GetLocationFromLocationMappingCmd won't modify the third parameter if it fails, so you could feed 'location' directly into it. -- To view, visit http://gerrit.cloudera.org:8080/11923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0efb327293d86168a30b05305f69d011ad15587a Gerrit-Change-Number: 11923 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 20 Nov 2018 00:22:19 +0000 Gerrit-HasComments: Yes
