Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11962 )
Change subject: [tools] Don't count tombstoned replicas in `kudu remote_replica check` ...................................................................... [tools] Don't count tombstoned replicas in `kudu remote_replica check` Counting them as not running made the tool pretty useless on any realistic cluster, where it's expected to have some tombstones. For example, it wasn't possible to use this tool to tell when all the tablet replicas on a tablet server had finished bootstrapping. I tested this against a server that previously failed the check because it had about 6000/10000 replicas tombstoned in STOPPED and INITIALIZED states. It now passes the check. Change-Id: Ibbdde768cce5f1d27064b7276944a585b41a2f03 Reviewed-on: http://gerrit.cloudera.org:8080/11962 Reviewed-by: Andrew Wong <aw...@cloudera.com> Tested-by: Kudu Jenkins Reviewed-by: Attila Bukor <abu...@apache.org> --- M src/kudu/tablet/metadata.proto M src/kudu/tools/tool_action_remote_replica.cc 2 files changed, 10 insertions(+), 5 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified Attila Bukor: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibbdde768cce5f1d27064b7276944a585b41a2f03 Gerrit-Change-Number: 11962 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
