Hello Alexey Serbin, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11969
to review the following change.
Change subject: build: explicitly declare decimal Set/Get<>s
......................................................................
build: explicitly declare decimal Set/Get<>s
Some compilers aren't clever enough to pick up on implicit instantiation
of templates based on usage in a given compilation unit, and instead we
need to explicitly instantiate them. This surfaced as the following
build error:
Undefined symbols for architecture x86_64:
"kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)15>
>(int, kudu::TypeTraits<(kudu::DataType)15>::cpp_type const&, bool)",
referenced from:
kudu::client::IntKeysTestSetup<kudu::client::KeyTypeWrapper<(kudu::DataType)15>
>::GenerateSplitRows(kudu::client::KuduSchema const&) const in
all_types-itest.cc.o
kudu::client::IntKeysTestSetup<kudu::client::KeyTypeWrapper<(kudu::DataType)15>
>::GenerateRowKey(kudu::client::KuduInsert*, int, int) const in
all_types-itest.cc.o
"kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)16>
>(int, kudu::TypeTraits<(kudu::DataType)16>::cpp_type const&, bool)",
referenced from:
kudu::client::IntKeysTestSetup<kudu::client::KeyTypeWrapper<(kudu::DataType)16>
>::GenerateSplitRows(kudu::client::KuduSchema const&) const in
all_types-itest.cc.o
kudu::client::IntKeysTestSetup<kudu::client::KeyTypeWrapper<(kudu::DataType)16>
>::GenerateRowKey(kudu::client::KuduInsert*, int, int) const in
all_types-itest.cc.o
"kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)17>
>(int, kudu::TypeTraits<(kudu::DataType)17>::cpp_type const&, bool)",
referenced from:
kudu::client::IntKeysTestSetup<kudu::client::KeyTypeWrapper<(kudu::DataType)17>
>::GenerateSplitRows(kudu::client::KuduSchema const&) const in
all_types-itest.cc.o
kudu::client::IntKeysTestSetup<kudu::client::KeyTypeWrapper<(kudu::DataType)17>
>::GenerateRowKey(kudu::client::KuduInsert*, int, int) const in
all_types-itest.cc.o
"kudu::Status
kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)15>
>(int, kudu::TypeTraits<(kudu::DataType)15>::cpp_type*) const", referenced from:
kudu::client::IntKeysTestSetup<kudu::client::KeyTypeWrapper<(kudu::DataType)15>
>::VerifyRowKey(kudu::client::KuduScanBatch::RowPtr const&, int, int) const in
all_types-itest.cc.o
"kudu::Status
kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)16>
>(int, kudu::TypeTraits<(kudu::DataType)16>::cpp_type*) const", referenced from:
kudu::client::IntKeysTestSetup<kudu::client::KeyTypeWrapper<(kudu::DataType)16>
>::VerifyRowKey(kudu::client::KuduScanBatch::RowPtr const&, int, int) const in
all_types-itest.cc.o
"kudu::Status
kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)17>
>(int, kudu::TypeTraits<(kudu::DataType)17>::cpp_type*) const", referenced from:
kudu::client::IntKeysTestSetup<kudu::client::KeyTypeWrapper<(kudu::DataType)17>
>::VerifyRowKey(kudu::client::KuduScanBatch::RowPtr const&, int, int) const in
all_types-itest.cc.o
Change-Id: If280f69b5736737a55862486c98f434cfb8e8072
---
M src/kudu/client/scan_batch.cc
M src/kudu/common/partial_row.cc
2 files changed, 40 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/11969/1
--
To view, visit http://gerrit.cloudera.org:8080/11969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If280f69b5736737a55862486c98f434cfb8e8072
Gerrit-Change-Number: 11969
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
