Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11968 )
Change subject: [webui] Fancy table for /mem-trackers and sortable tables ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js File www/kudu.js: http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js@18 PS1, Line 18: // Converts a human-readable bytes value like '1.23B' or '985.32M' to a number : // of bytes. The suffix must be present: '1.23' is not valid but '1.23B' is. > Seems like we could relax the suffix restriction if we parsed the last byte Yeah, but I think it's not necessary and it makes the code more complicated. There's also the technical point that 1.23 != 1.23B, just like 1 != 1 foot. Also, this function is meant to invert HumanReadableNumBytes::ToString, which always includes the suffix. http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js@41 PS1, Line 41: case 'k': val *= 1024.0; > Curious why we do special treatment for lower-case k but not for any of the Well, frankly, it's because I copied the body of the switch statement from HumanReadableBytes::ToDouble (except for a really terrible joke comment good riddance) and it handles 'K' and 'k'. HumanReadableNumBytes::ToString emits only 'K' so I can remove handling for 'k'. http://gerrit.cloudera.org:8080/#/c/11968/1/www/maintenance-manager.mustache File www/maintenance-manager.mustache: http://gerrit.cloudera.org:8080/#/c/11968/1/www/maintenance-manager.mustache@66 PS1, Line 66: Ram > Nit: isn't 'RAM' a more precise term though? Whoops. Messed up when I rewrote it. -- To view, visit http://gerrit.cloudera.org:8080/11968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 Gerrit-Change-Number: 11968 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <mbarn...@cloudera.com> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 21 Nov 2018 00:54:47 +0000 Gerrit-HasComments: Yes
