Brock Noland has posted comments on this change. ( http://gerrit.cloudera.org:8080/4491 )
Change subject: KUDU-1563. Add support for INSERT IGNORE ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/4491/17//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/4491/17//COMMIT_MSG@9 PS17, Line 9: Adds `INSERT IGNORE' operation which behaves like a : normal `INSERT' except in the case when a duplicate : row error would be raised by the primary key having been : previously inserted. > Hmm, I thought the feedback from Dan and MJ in KUDU-1563 was to broaden the I understand MJ's suggestion as making a very extensible framework where a client could say provide a tuple of an operation and *any error* and have them ignored. I might have misread but I wasn't sold on that. Feels like it's ripe for confusion since in some situations the error returned will change over time. I am also not sure I want to ignore every error. For example for my use case, I want to ignore DUPLICATE KEY errors but I definitely do not want to ignore any other errors because I am very concerned about data loss. However, I do think there is a middle ground where we can make this more extensible but only allow the user to ignore errors on the server side when we feel as a community there ie a valid use case for ignoring that error. In terms of making it more extensible, what makes sense to mean is: * Have a session property which defines a set of modes. eg INSERT_IGNORE_DUPLICATE_KEY, DELETE_IGNORE_MISSING_KEY, etc * Each "mode" is implemented by Kudu developers for use cases which feel is "safe" and "makes sense" * I'll add INSERT_IGNORE_DUPLICATE_KEY which behaves like this patch and then others can add more capabilities as they see fit. I think that is an easy to use interface, safe, and reduces the implementation burden for this change. -- To view, visit http://gerrit.cloudera.org:8080/4491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bfc35e9d27bd5e2d3375b68e6e4716ed671f36c Gerrit-Change-Number: 4491 Gerrit-PatchSet: 17 Gerrit-Owner: Brock Noland <br...@phdata.io> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Brock Noland <br...@phdata.io> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 04 Dec 2018 05:43:48 +0000 Gerrit-HasComments: Yes
