Hello Will Berkeley, Adar Dembo, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12054
to review the following change.
Change subject: [build] Fix bulding codegen on MacOS Mojave
......................................................................
[build] Fix bulding codegen on MacOS Mojave
The codegen target uses clang-6.0 from thirdparty even on macOS, after
upgrading to macOS Mojave and Xcode 10 the build failed due to changes
in where the SDK is located.
Xcode 10's release notes claim the macOS headers are no longer installed
in the base system under /usr/include[1].
This commit locates the headers using "xcrun --show-sdk-path" and passes
this path as "--sysroot" to clang.
[1]
https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes
Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29
---
M src/kudu/codegen/CMakeLists.txt
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12054/1
--
To view, visit http://gerrit.cloudera.org:8080/12054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29
Gerrit-Change-Number: 12054
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
