Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12061 )
Change subject: [Java] Add a Schema and Data Generator ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/12061/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12061/1//COMMIT_MSG@9 PS1, Line 9: This patch adds a schema and data generator utility : class > Nit: This patch adds schema and data generate utility classes Done http://gerrit.cloudera.org:8080/#/c/12061/1//COMMIT_MSG@11 PS1, Line 11: usefull > useful Done http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java File java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java: PS1: > License header. Done http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java@58 PS1, Line 58: public void randomizeRow(PartialRow row) { > Seems redundant to have both randomizeRow and randomRow. The TestKuduBackup Done http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java@97 PS1, Line 97: i++; > It's easy to miss this; perhaps convert into a for loop on i (capped at col Done http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java@129 PS1, Line 129: public static class DataGeneratorBuilder { > Since the only way to create a DataGenerator is through here, maybe doc thi Done http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java File java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java: PS1: > License header. Done -- To view, visit http://gerrit.cloudera.org:8080/12061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I750d2d346c3eeb7075b21c3fec0fd25236da4f56 Gerrit-Change-Number: 12061 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 12 Dec 2018 22:09:10 +0000 Gerrit-HasComments: Yes
