Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11956 )
Change subject: [sentry] add mini Sentry to the external mini cluster ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/11956/9/src/kudu/sentry/mini_sentry.h File src/kudu/sentry/mini_sentry.h: http://gerrit.cloudera.org:8080/#/c/11956/9/src/kudu/sentry/mini_sentry.h@99 PS9, Line 99: std::string ip_{"0.0.0.0"}; > Sorry for the confusion; my comment was just surprise that "Foo f_ = ..." s Thanks for the explanation. Yes, this is legal. Referred ยง12.6.2/8 of C++11 draft (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3690.pdf): In a non-delegating constructor, if a given non-static data member or base class is not designated by a mem-initializer-id (including the case where there is no mem-initializer-list because the constructor has no ctor-initializer) and the entity is not a virtual base class of an abstract class (10.4), then if the entity is a non-static data member that has a brace-or-equal-initializer, the entity is initialized as specified in 8.5; For narrowing conversion, I agree this is not related to the usage here. I will switch it back. -- To view, visit http://gerrit.cloudera.org:8080/11956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f02e6085bd239570d10ec629f48856d37ed6e59 Gerrit-Change-Number: 11956 Gerrit-PatchSet: 9 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 13 Dec 2018 02:24:11 +0000 Gerrit-HasComments: Yes