Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 )
Change subject: De-flake sentry tests ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11961/4/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/11961/4/src/kudu/util/net/net_util.cc@451 PS4, Line 451: static const int kServerIdxBits = 24 - kPidBits; You can reuse this constant in kServersMaxNum too. http://gerrit.cloudera.org:8080/#/c/11961/4/src/kudu/util/net/net_util.cc@452 PS4, Line 452: CHECK(0 < index && index <= kServersMaxNum) << Substitute( I think I missed something: why did the requirements of 'index' change such that 0 < index <= max_servers instead of 0 <= index < max_servers? The former is more intuitive; it's more natural to see intervals that are closed on the lower bound and open on the upper bound. -- To view, visit http://gerrit.cloudera.org:8080/11961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id112634ad5e6f0e2c48b7e0e89389faff4f5656b Gerrit-Change-Number: 11961 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 13 Dec 2018 05:38:23 +0000 Gerrit-HasComments: Yes
