Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12002 )
Change subject: KUDU-683: unify C++ client-to-master retry logic ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/12002/5/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/12002/5/src/kudu/client/client-internal.cc@162 PS5, Line 162: nit: extra space. http://gerrit.cloudera.org:8080/#/c/12002/5/src/kudu/client/master_proxy_rpc.h File src/kudu/client/master_proxy_rpc.h: http://gerrit.cloudera.org:8080/#/c/12002/5/src/kudu/client/master_proxy_rpc.h@95 PS5, Line 95: Status* status nit: doc what the 'status' out param means? http://gerrit.cloudera.org:8080/#/c/12002/5/src/kudu/client/master_proxy_rpc.h@122 PS5, Line 122: required_feature_flags_ nit: doc what this is for? http://gerrit.cloudera.org:8080/#/c/12002/5/src/kudu/client/master_proxy_rpc.cc File src/kudu/client/master_proxy_rpc.cc: http://gerrit.cloudera.org:8080/#/c/12002/5/src/kudu/client/master_proxy_rpc.cc@92 PS5, Line 92: nit: extra space. http://gerrit.cloudera.org:8080/#/c/12002/5/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/12002/5/src/kudu/client/meta_cache.cc@731 PS5, Line 731: if (new_status.IsServiceUnavailable()) { Can you explain a bit more here why RetryOrReconnectIfNecessary() cannot handle this case? -- To view, visit http://gerrit.cloudera.org:8080/12002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2450676da1c723a247c84deb1b895f116173670e Gerrit-Change-Number: 12002 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 14 Dec 2018 21:23:42 +0000 Gerrit-HasComments: Yes