Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11798 )
Change subject: [docs] add Hive Metastore integration ...................................................................... Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/11798/6/docs/hive_metastore.adoc File docs/hive_metastore.adoc: http://gerrit.cloudera.org:8080/#/c/11798/6/docs/hive_metastore.adoc@76 PS6, Line 76: Additionally, the Hive Metastore does not enforce case sensitivity for table name : identifiers. As such, when enabled, Kudu will follow suit and disallow tables : from being created when one already exists whose table name identifier differs : only by case. Operations that open, alter, or drop tables will also be : case-insensitive for the table name identifiers. : > nit reword a bit: "Additionally, the HMS does not enforce case sensitivity Done http://gerrit.cloudera.org:8080/#/c/11798/6/docs/hive_metastore.adoc@86 PS6, Line 86: > tiny nit: "and to allow" Done http://gerrit.cloudera.org:8080/#/c/11798/6/docs/hive_metastore.adoc@87 PS6, Line 87: ration > nit: missing space Done http://gerrit.cloudera.org:8080/#/c/11798/6/docs/hive_metastore.adoc@119 PS6, Line 119: ``` : : * Restart the Kudu master(s). > Can you make this a warning, and move this up to just before "## Enabling t Done http://gerrit.cloudera.org:8080/#/c/11798/6/docs/hive_metastore.adoc@125 PS6, Line 125: conflicting tables before enabling the Hive Metastore integration. : : ## Upgrading Existing Tables : : When the Hive Metastore integration is enabled, Kudu will automatically synchronize : changes to Kudu tables between Kudu and the HMS. As such, it is important to ensure : that the Kudu and HMS start with a consistent view of existing tables, using the : administrative tools described in the next section. This may entail renaming Kudu : tables to conform to the Hive naming constraints described above. Failure to do : so may result in metadata inconsistencies between Kudu and the HMS, such as existing : Kudu tab > I think here might be a good place to call out what the integration is doin Done http://gerrit.cloudera.org:8080/#/c/11798/6/docs/hive_metastore.adoc@156 PS6, Line 156: : The `kudu hms fix` tool analyzes the Kudu and H > nit: make this one sentence: "...automatically-fixable issues, for instance Done http://gerrit.cloudera.org:8080/#/c/11798/6/docs/hive_metastore.adoc@159 PS6, Line 159: that doesn't already have one. The `dryrun` option : > nit: "how a manual fix can help." Done http://gerrit.cloudera.org:8080/#/c/11798/6/docs/hive_metastore.adoc@161 PS6, Line 161: ix can > nit: "grained" Done -- To view, visit http://gerrit.cloudera.org:8080/11798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 Gerrit-Change-Number: 11798 Gerrit-PatchSet: 7 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 Dec 2018 22:05:22 +0000 Gerrit-HasComments: Yes
