Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12112 )
Change subject: [util] use lighter locking scheme for ThreadMgr ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12112/2/src/kudu/util/thread.cc File src/kudu/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/12112/2/src/kudu/util/thread.cc@304 PS2, Line 304: void ThreadMgr::AddThread(const pthread_t& pthread_id, const string& name, You sure it's OK to remove the annotations? Commit 5693f6910 added them under the assumption that without the annotations, TSAN won't find certain data races. http://gerrit.cloudera.org:8080/#/c/12112/2/src/kudu/util/thread.cc@338 PS2, Line 338: DCHECK(!lock_.is_locked()); I thought you said this isn't safe; there could be a concurrent caller adding or removing a thread, no? -- To view, visit http://gerrit.cloudera.org:8080/12112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d49c1c39392e01c45019844430a4fe3d116c277 Gerrit-Change-Number: 12112 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 05:23:53 +0000 Gerrit-HasComments: Yes
