Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12002 )
Change subject: KUDU-683: unify C++ client-to-master retry logic ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/12002/6/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/12002/6/src/kudu/client/meta_cache.cc@560 PS6, Line 560: string ToString() const override; > Right, I guess what I'm advocating for is that SendRpcSlowPath() is renamed To close the loop on this, we chatted about this in #kudu-general. We batted around this suggestion wrt what it would look like and whether it'd be worth it to refactor AsyncLeaderMasterRpc to make LookupRpc feel more natural, and the conclusion settled on was that the answer is no, given that other/future RPCs likely don't look much like LookupRpc in terms of pre-checks and whatnot. Notably, there's a meta-cache-check, as well as a permit acquisition bundled into LookupRpc, and it's not easy to model this with the addition of a single PreSendRpc() hook, given the current usages. -- To view, visit http://gerrit.cloudera.org:8080/12002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2450676da1c723a247c84deb1b895f116173670e Gerrit-Change-Number: 12002 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 22 Dec 2018 02:57:30 +0000 Gerrit-HasComments: Yes
