Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract ...................................................................... Patch Set 1: (3 comments) I think you will need to rebase onto Mikes Classloader patc and fix the collisions. http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/build.gradle File java/kudu-test-utils/build.gradle: http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/build.gradle@23 PS1, Line 23: compile libs.osdetector > This looks good. I wonder if Grant can help us ensure it's shaded. This will be shaded given the shadow.gradle script is applied and it's in compile scope. http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java: http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@52 PS1, Line 52: private static OsDetector DETECTOR = new OsDetector(); nit: final http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@67 PS1, Line 67: if (DETECTOR.getOs().equals(props.getProperty("artifact.os")) && Should we log the OS and ARCH that we detected at INFO level for debugging purposes? -- To view, visit http://gerrit.cloudera.org:8080/12141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c Gerrit-Change-Number: 12141 Gerrit-PatchSet: 1 Gerrit-Owner: Brian McDevitt <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 03 Jan 2019 15:58:33 +0000 Gerrit-HasComments: Yes
