Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12154 )
Change subject: [build-and-test] add short-circuiting for RUN_FLAKY_ONLY ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12154/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12154/1//COMMIT_MSG@10 PS1, Line 10: don't build : anything and report success right away. The placement of the new code is such that we'll still run through the thirdparty build though; I thought you wanted to short-circuit that too? http://gerrit.cloudera.org:8080/#/c/12154/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/12154/1/build-support/jenkins/build-and-test.sh@210 PS1, Line 210: just re-run those Nit: "run just flaky tests" http://gerrit.cloudera.org:8080/#/c/12154/1/build-support/jenkins/build-and-test.sh@212 PS1, Line 212: if [ "$RUN_FLAKY_ONLY" == "1" -o "$KUDU_FLAKY_TEST_ATTEMPTS" -gt 1 ]; then Don't we have to get the flaky test list regardless of whether RUN_FLAKY_ONLY is 1? That's what the old code did. -- To view, visit http://gerrit.cloudera.org:8080/12154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c Gerrit-Change-Number: 12154 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 04 Jan 2019 00:25:47 +0000 Gerrit-HasComments: Yes
