Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12153 )
Change subject: build: Factor dependency extraction code from dist_test into a python library ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12153/1/build-support/dep_extract.py File build-support/dep_extract.py: PS1: > What's the reasoning behind that? This class is pretty specialized whereas Just thought it'd be a good place to collect all utility code. But I don't feel strongly about it. -- To view, visit http://gerrit.cloudera.org:8080/12153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b4cbfceb053c61dbb1f1d16716acc8926987af2 Gerrit-Change-Number: 12153 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 04 Jan 2019 00:44:34 +0000 Gerrit-HasComments: Yes
