Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )
Change subject: [c++] remove -Wno-deprecated compiler's flag ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12140/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12140/2//COMMIT_MSG@11 PS2, Line 11: 'pragma GCC diagnostic' > These don't cause warnings when building with clang do they? That pragma works both for gcc (version 4.6 and higher) and clang, so no warnings when building with clang. IIRC, we require at least GCC4.8 to build Kudu from source because of C++11 support, so that should be OK. http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/client-test.cc@1152 PS2, Line 1152: // TODO: consider fixing this to support returning the column multiple > warning: missing username/bug in TODO [google-readability-todo] I'm going to punt on this. http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/schema.h@253 PS2, Line 253: #pragma GCC diagnostic push > This being client/schema.h, is this pragma recognized by el6's version of g Added ifdefs to target for the gcc versions that supports push/pop for that diagnostic warning. http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/integration-tests/linked_list-test-util.h File src/kudu/integration-tests/linked_list-test-util.h: http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/integration-tests/linked_list-test-util.h@470 PS2, Line 470: Status LinkedListTester::CreateLinkedListTable() { > warning: function 'CreateLinkedListTable' defined in a header file; functio I'm going to punt on this warning. -- To view, visit http://gerrit.cloudera.org:8080/12140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759 Gerrit-Change-Number: 12140 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 04 Jan 2019 02:02:49 +0000 Gerrit-HasComments: Yes
