Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12208 )
Change subject: [examples] a small update on SparkExample ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12208/2/examples/scala/spark-example/src/main/scala/org/apache/kudu/spark/examples/SparkExample.scala File examples/scala/spark-example/src/main/scala/org/apache/kudu/spark/examples/SparkExample.scala: http://gerrit.cloudera.org:8080/#/c/12208/2/examples/scala/spark-example/src/main/scala/org/apache/kudu/spark/examples/SparkExample.scala@43 PS2, Line 43: avaialble typo http://gerrit.cloudera.org:8080/#/c/12208/2/examples/scala/spark-example/src/main/scala/org/apache/kudu/spark/examples/SparkExample.scala@44 PS2, Line 44: tableReplicasNum: Int = Integer.getInteger("tableReplicasNum" nit: maybe tableNumReplicas? http://gerrit.cloudera.org:8080/#/c/12208/2/examples/scala/spark-example/src/main/scala/org/apache/kudu/spark/examples/SparkExample.scala@81 PS2, Line 81: if (!kuduContext.tableExists(tableName)) { > Instead should we just fail if it already exists? At first I leaned towards going ahead if the table exists, but on second thought maybe we should fail since we expect a specific schema, etc. -- To view, visit http://gerrit.cloudera.org:8080/12208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf8c4e675ca6c240582242658fa8173a1ccd271d Gerrit-Change-Number: 12208 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <mbarn...@cloudera.com> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 10 Jan 2019 04:01:36 +0000 Gerrit-HasComments: Yes
