Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12218 )
Change subject: docs: Add Gerrit HTTP endpoint instructions ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc File docs/contributing.adoc: http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@43 PS1, Line 43: . Go to link:http://gerrit.cloudera.org:8080/#/settings/[Settings]. Update your name > Should we offer a recommendation for which protocol to use? Done http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@52 PS1, Line 52: . If you have not done so, clone the main Kudu repository. By default, the main remote > This got renumbered in the render (it's now a new numbered list instead of Thanks for the catch, fixed http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@64 PS1, Line 64: If you have uploaded an SSH public key (see above) and would like to use SSH to : connect to Gerrit, > Nit: more terse as "If using SSH to connect to Gerrit, ..." Done http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@73 PS1, Line 73: If you have generated an HTTP password (see above) and would like to use HTTP > Nit: more terse as "If using HTTP or HTTPS to connect to Gerrit, ..." Done http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@84 PS1, Line 84: If you are using the HTTP / HTTPS endpoint for Gerrit and prefer not to type a > Nit: "If you are using Gerrit's HTTP or HTTPS endpoints and prefer..." Done -- To view, visit http://gerrit.cloudera.org:8080/12218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2 Gerrit-Change-Number: 12218 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Fri, 11 Jan 2019 21:45:05 +0000 Gerrit-HasComments: Yes