Hello Mike Percy, Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12223
to review the following change.
Change subject: generic_iterators: move iterator declarations into cc file
......................................................................
generic_iterators: move iterator declarations into cc file
I plan on converting MergeIterator's state vector into an intrusive list,
which means MergeIterState's class definition needs to be visible to
MergeIterator's class definition.
Instead of moving MergeIterState into the header, let's go the other way and
move all of the iterator declarations into the .cc file. The code outside of
these classes doesn't care about the concrete types, and it should speed up
compilation a bit.
I had to poke a hole in for some PredicateEvaluatingIterator tests though.
Change-Id: I301f39ec0d55b73cadcf28d8104accca3219ab1b
---
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/generic_iterators.cc
M src/kudu/common/generic_iterators.h
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/tablet.cc
9 files changed, 341 insertions(+), 315 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/12223/1
--
To view, visit http://gerrit.cloudera.org:8080/12223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I301f39ec0d55b73cadcf28d8104accca3219ab1b
Gerrit-Change-Number: 12223
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
