Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12196 )
Change subject: generic_iterators: prep for MergeIterator dominance ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12196/1/src/kudu/common/generic_iterators.h File src/kudu/common/generic_iterators.h: http://gerrit.cloudera.org:8080/#/c/12196/1/src/kudu/common/generic_iterators.h@184 PS1, Line 184: > I don't know; I didn't measure the impact of the histogram itself. Looking yea I think a single counter should be low enough overhead that i'm not too concerned, especially considering we expect your improvements to have a really large perf improvement associated -- To view, visit http://gerrit.cloudera.org:8080/12196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a8db5973dc09b7271e05b3cc28025b7a2a9e21b Gerrit-Change-Number: 12196 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 12 Jan 2019 00:28:36 +0000 Gerrit-HasComments: Yes
