Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] throw exception if applying operation on a closed session ...................................................................... Patch Set 4: > Like you said, this is a breaking change given user code could > start failing at runtime on upgrade. > > A hacky alternative to make the re-use bug safer could be to add > the session back to the client on re-use. It defeats the purpose of > closing, but prevents a bug without breaking the api. Or can we log a warning instead if to avoid breaking changes? -- To view, visit http://gerrit.cloudera.org:8080/12237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9 Gerrit-Change-Number: 12237 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 18 Jan 2019 06:14:50 +0000 Gerrit-HasComments: No
