Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12157 )
Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock ...................................................................... generic_iterators: short-circuit MergeIterState::PullNextBlock This is a micro-optimization to avoid testing every bit in the selection vector when we've already counted up the number of set bits. There was a lack of selection vector coverage in the existing fuzzy merge tests, so I've modified them to randomly use one, and added a new test too. Change-Id: I529e632f40943962d34c184b29b5cff7604ad59b Reviewed-on: http://gerrit.cloudera.org:8080/12157 Tested-by: Adar Dembo <a...@cloudera.com> Reviewed-by: Mike Percy <mpe...@apache.org> --- M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/rowblock.h 3 files changed, 97 insertions(+), 36 deletions(-) Approvals: Adar Dembo: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I529e632f40943962d34c184b29b5cff7604ad59b Gerrit-Change-Number: 12157 Gerrit-PatchSet: 10 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
