Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12276 )
Change subject: [java] deflake RYW tests in TestKuduClient ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12276/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12276/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1084 PS1, Line 1084: : AsyncKuduScanner scanner = asyncClient.newScannerBuilder(table) : .readMode(AsyncKuduScanner.ReadMode.READ_YOUR_WRITES) : .replicaSelection(replicaSelection) : .build(); : KuduScanner syncScanner = new KuduScanner(scanner); I don't see anything in this block of code that would cause the client's lastPropagatedTimestamp value to change. How does moving the initialization of preTs address the flakiness? http://gerrit.cloudera.org:8080/#/c/12276/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1090 PS1, Line 1090: assertNotEquals(AsyncKuduClient.NO_TIMESTAMP, : asyncClient.getLastPropagatedTimestamp()); Should this test preTs instead of a new call to getLastPropagatedTimestamp? -- To view, visit http://gerrit.cloudera.org:8080/12276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I951abb9197f7e6b6a4c70cdf89948206840ddeda Gerrit-Change-Number: 12276 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 27 Jan 2019 18:38:06 +0000 Gerrit-HasComments: Yes
