Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12281 )
Change subject: [tools] Describe more table attributes ...................................................................... Patch Set 2: (10 comments) Looks pretty good. Thanks for adding this. http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@9 PS2, Line 9: its Remove. http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@9 PS2, Line 9: describe a table `kudu table describe` http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@9 PS2, Line 9: add adds http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@11 PS2, Line 11: of for http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@13 PS2, Line 13: texts text http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.h@233 PS2, Line 233: bool with_attributes = false Can you replace this bool parameter with an enum? See https://abseil.io/tips/94 for more information and justification. http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.cc@140 PS2, Line 140: "-" This is sort of silly, but what if the default is "-"? Also, what if the default is some giant multiline string, like if the default is itself a stringified Kudu schema. Do you think those cases aren't worth doing more work to cover nicely? Or should we adopt some sort of escaping scheme? http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/tools/kudu-admin-test.cc@1761 PS2, Line 1761: ->Precision(10) Can you up the precision here to make sure we test int128 values? I think 30 or so is high enough. http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/tools/kudu-admin-test.cc@1796 PS2, Line 1796: kAnotherTableId, : "-show_attributes=true" Can you run the tool twice: with and without this flag, to check that the output appears with the flag and doesn't appear without the flag? http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/util/int128_util.h File src/kudu/util/int128_util.h: http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/util/int128_util.h@18 PS2, Line 18: #ifndef KUDU_INT128_UTIL_H : #define KUDU_INT128_UTIL_H Prefer #pragma once. -- To view, visit http://gerrit.cloudera.org:8080/12281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8 Gerrit-Change-Number: 12281 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Mon, 28 Jan 2019 19:41:45 +0000 Gerrit-HasComments: Yes
