Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12308 )
Change subject: KUDU-2665: LBM may delete containers with live blocks ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/12308/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12308/2//COMMIT_MSG@12 PS2, Line 12: That's because > sorry, i have no idea. what does 'dist-test' mean? Our jenkins job are using dist-test to have efficient test runs (tests are submitted to a distributed testing service running on shared infrastructure, https://github.com/apache/kudu/blob/master/build-support/dist_test.py) It has a feature to allow you to loop a certain test multiple times. Though interestingly, I just tried to loop the test (without your fix) and have no luck of reproduce the error. http://gerrit.cloudera.org:8080/#/c/12308/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/12308/2/src/kudu/fs/log_block_manager.cc@1549 PS2, Line 1549: container_->blocks_being_written_incr(-1); > yep, that's a very good point. Sounds good, would you mind adding a comment here to explain it? -- To view, visit http://gerrit.cloudera.org:8080/12308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I894f32b1c164ae7770c92171850edd167dfaf8ad Gerrit-Change-Number: 12308 Gerrit-PatchSet: 3 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Fri, 01 Feb 2019 19:32:53 +0000 Gerrit-HasComments: Yes
