Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12261 )
Change subject: [spark] Add write duration histograms ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12261/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/HdrHistogramAccumulator.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/HdrHistogramAccumulator.scala: http://gerrit.cloudera.org:8080/#/c/12261/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/HdrHistogramAccumulator.scala@63 PS1, Line 63: other.asInstanceOf[HdrHistogramAccumulator].histogram.inner_histogram) > Can you use `other.value` here in place of `.asInstanceOf[HdrHistogramAccum Done http://gerrit.cloudera.org:8080/#/c/12261/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/HdrHistogramAccumulator.scala@80 PS1, Line 80: extends Serializable { > Is SynchronizedHistogram serializable? SynchornizedHistogram extends Histogram extends AbstractHistogram extends Serializable. -- To view, visit http://gerrit.cloudera.org:8080/12261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fd4d380b08bd7d7d5c1e65b79cffb44a9b9d433 Gerrit-Change-Number: 12261 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 05 Feb 2019 19:24:16 +0000 Gerrit-HasComments: Yes
