Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12371 )
Change subject: [docker] Optimize kudu image size ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/12371/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12371/1//COMMIT_MSG@22 PS1, Line 22: reduced nit: reduce http://gerrit.cloudera.org:8080/#/c/12371/1/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/12371/1/docker/Dockerfile@148 PS1, Line 148: # Use the bash shell for all RUN commands. : SHELL ["/bin/bash", "-c"] Why is this here and not somewhere higher, like in base or something? http://gerrit.cloudera.org:8080/#/c/12371/1/docker/bootstrap-runtime-env.sh File docker/bootstrap-runtime-env.sh: http://gerrit.cloudera.org:8080/#/c/12371/1/docker/bootstrap-runtime-env.sh@34 PS1, Line 34: # Install runtime packages. Perhaps add a TODO about NTP if we don't want to support that just yet? -- To view, visit http://gerrit.cloudera.org:8080/12371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a1fdad54744a1680d362f59433e94749f35469f Gerrit-Change-Number: 12371 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 05 Feb 2019 21:30:42 +0000 Gerrit-HasComments: Yes
