Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12380 )

Change subject: [docker] Add publish support to the build script
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12380/2/docker/docker-build.sh
File docker/docker-build.sh:

http://gerrit.cloudera.org:8080/#/c/12380/2/docker/docker-build.sh@206
PS2, Line 206:     # Add the latest version tags.
             :     if [[ "$TAG_LATEST" == "1" ]]; then
             :       LATEST_TAG=$(get_tag "$TARGET" "latest" "$OS_TAG")
             :       docker tag "$FULL_TAG" "$LATEST_TAG"
             :       TAGS+=("$LATEST_TAG")
             :
             :       # Add the default OS tag.
             :       if [[ "$BASE_OS" == "$DEFAULT_OS" ]]; then
             :         LATEST_DEFAULT_OS_TAG=$(get_tag "$TARGET" "latest" "")
             :         docker tag "$FULL_TAG" "$LATEST_DEFAULT_OS_TAG"
             :         TAGS+=("$LATEST_DEFAULT_OS_TAG")
             :       fi
             :     fi
As this becomes more integrated with our release process, will this get rid of 
old "latest" tags? Or will that need to be done manually?



--
To view, visit http://gerrit.cloudera.org:8080/12380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdc018f89da0a44ad76fae772aaede8eb5263d5d
Gerrit-Change-Number: 12380
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 04:50:55 +0000
Gerrit-HasComments: Yes

Reply via email to