Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12205
to look at the new patch set (#3).
Change subject: KUDU-2645: tablet: Support deduplication of deleted rows in
MergeIterator
......................................................................
KUDU-2645: tablet: Support deduplication of deleted rows in MergeIterator
This patch makes it possible to do an incremental diff scan of an entire
tablet. A follow-up patch will expose this capability to scanners at the
RPC level.
Included is new support in the MergeIterator for deduplicating deleted
rows resulting from when a row with a particular primary key is deleted
from one rowset and reinserted into a different rowset. These duplicates
may be returned when the 'include_deleted_rows' option is enabled in the
row iterator options.
Because of this new behavior, while the MergeIterator will deduplicate
deleted rows if they are included in the result set, the UnionIterator
will not deduplicate them and instead return all instances found.
One tangentially-related change in this patch is that TestMerge in
generic_iterators-test.cc was modified to no longer generate duplicate
non-deleted keys for merge testing. Duplicate non-deleted row keys are
no longer supported in the MergeIterator since there is currently no
practical use for that, and it's more efficient not to support them
since at the time of writing it isn't possible for them to appear in a
real tablet.
Change-Id: I00614b3fa5c6b4e7b620bb78489e24c5ad44daee
---
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/generic_iterators.cc
M src/kudu/common/generic_iterators.h
M src/kudu/tablet/diff_scan-test.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/tablet.cc
6 files changed, 176 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/12205/3
--
To view, visit http://gerrit.cloudera.org:8080/12205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00614b3fa5c6b4e7b620bb78489e24c5ad44daee
Gerrit-Change-Number: 12205
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
