Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12435 )
Change subject: [client] Improve message when setting a decimal on a non-decimal column ...................................................................... [client] Improve message when setting a decimal on a non-decimal column This patch improves the error messaging when setting a decimal on a non-decimal column. Changes the order of validation operations to first check the column type is valid before checking the value is in range. Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 Reviewed-on: http://gerrit.cloudera.org:8080/12435 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/client/scan_batch.cc M src/kudu/common/partial_row-test.cc M src/kudu/common/partial_row.cc 3 files changed, 19 insertions(+), 6 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: merged Gerrit-Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 Gerrit-Change-Number: 12435 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
