Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/12446 )
Change subject: [client] Fix GetUnscaledDecimal backward compatiblity
......................................................................
Patch Set 1:
> I was thinking of ignoring IWYU given I didn't change any usage behavior and
> the changes seem pretty arbitrary.
FWIW, the recommendations make sense to me:
1. foo-test.cc should include foo.h first. So it makes sense to move the
partial_row.h inclusion to the top.
2. partial_row-test.cc probably does need to include int128.h on account of the
{Get,Set}UnscaledDecimal calls.
--
To view, visit http://gerrit.cloudera.org:8080/12446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bce3f6df6a09327a503f2793ed1317e147349c9
Gerrit-Change-Number: 12446
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 12 Feb 2019 21:07:55 +0000
Gerrit-HasComments: No
