Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12450 )
Change subject: [tools] Add useful flags to 'kudu remote_replica list' ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12450/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/12450/2/src/kudu/tools/kudu-tool-test.cc@1949 PS2, Line 1949: foo > Does it make sense to check for the 'positive case' as well (i.e. specify Hm yeah, I thought I had a test case for that. http://gerrit.cloudera.org:8080/#/c/12450/2/src/kudu/tools/kudu-tool-test.cc@1964 PS2, Line 1964: Finally, tombstone the replica and try again > Do we expect the schema to be present in the output? If yes, maybe add tha It just depends on the flag. We already checked if the flag works in a previous test. -- To view, visit http://gerrit.cloudera.org:8080/12450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I462515f1bc3e8487185aebb6cb99d1c5c00cea40 Gerrit-Change-Number: 12450 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 15 Feb 2019 19:12:37 +0000 Gerrit-HasComments: Yes
