Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12204 to look at the new patch set (#5). Change subject: KUDU-2645: schema: Add support for virtual columns in projections ...................................................................... KUDU-2645: schema: Add support for virtual columns in projections * Do not validate that virtual columns appearing in a user projection also appear in the tablet schema because virtual columns are not physically present and so should never appear in a tablet schema. * Generate artificial column ids for virtual columns so that we can map the virtual columns onto a scanner schema that includes column ids, like a tablet iterator. Schemas have the invariant that either there are no column ids present in a schema or all columns in the schema are mapped to a column id. This patch adds a simple unit test for Schema::GetMappedReadProjection() that includes the use of a virtual column. Change-Id: I06a69ab9d65245e25b1a955765a3a1ebdb9655d3 --- M src/kudu/common/schema-test.cc M src/kudu/common/schema.cc 2 files changed, 46 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/12204/5 -- To view, visit http://gerrit.cloudera.org:8080/12204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I06a69ab9d65245e25b1a955765a3a1ebdb9655d3 Gerrit-Change-Number: 12204 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>